avd icon indicating copy to clipboard operation
avd copied to clipboard

Feat(eos_config_deploy_cvp): Updated cv_collection version to v3 by default

Open sugetha24 opened this issue 2 years ago • 4 comments

Change Summary

Updated cv_collection: v3 variable to use v3 cv collection by default

Related Issue(s)

Fixes #1796

Component(s) name

arista.avd.eos_config_deploy_cvp

Proposed changes

cv_collection: v1 to cv_collection: v3 in https://github.com/aristanetworks/ansible-avd/blob/devel/ansible_collections/arista/avd/roles/eos_config_deploy_cvp/defaults/main.yml

How to test

molecule converge --scenario-name eos_config_deploy_cvp Also, manually tested the role.

Checklist

User Checklist

  • N/A

Repository Checklist

  • [x] My code has been rebased from devel before I start
  • [x] I have read the CONTRIBUTING document.
  • [x] My change requires a change to the documentation and documentation have been updated accordingly.
  • [x] I have updated molecule CI testing accordingly. (check the box if not applicable)

sugetha24 avatar Jun 14 '22 18:06 sugetha24

Adding what I posted on google chat here:

So I did not have time to conduct extended testing - I was questioning in my first comment if using “non fqdn” in the fqdn field would cause an issue. After some troubleshooting there is cuurently no way to tell ansible-avd to call the ansible-cvdptask(s) with a different search_key so by default we end up using host name as search_key (as per ansible-cvp code) so I don’t know the implications of the pr

From my initial it “looks to be working” except that we end up with “non valid fqdn” in the fqdn fields. For now it seems it does not have any impact (given that we will always use hostname as search key) but I think it could get some when we modify ansible-avd role to use different search_key in the case where the fqdn is different from the host name (I.e. there is a dns domain configured on the device)

gmuloc avatar Jun 23 '22 20:06 gmuloc

This branch has conflicts. Needs a rebase, I couldn't do it with github Update branch

tgodaA avatar Jul 02 '22 02:07 tgodaA

So in this PR we are removing both V1 and V3. But is there a reason to still keep the v1 and v3 directories. I don't see any type of call from the actual main.yml.

If so we can delete the v1 and v3 directories as they still have some main.yml files.

tgodaA avatar Jul 04 '22 16:07 tgodaA

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 27 '22 19:07 github-actions[bot]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days

github-actions[bot] avatar Oct 26 '22 00:10 github-actions[bot]

This PR is stale because it has been open 30 days with no activity. The PR will be reviewed by a maintainer and may be closed

github-actions[bot] avatar Apr 15 '23 00:04 github-actions[bot]

Replaced with #2882 for now, since we are not ready to remove v1 support until we have feature parity.

ClausHolbechArista avatar May 26 '23 19:05 ClausHolbechArista