aws-cdk-github-oidc icon indicating copy to clipboard operation
aws-cdk-github-oidc copied to clipboard

feat: support passing multiple trustedRepositories

Open blimmer opened this issue 1 year ago • 6 comments

This PR introduces a new API that allows passing multiple subjects via the trustedRepositories property.

Fixes #35

blimmer avatar Nov 10 '23 23:11 blimmer

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
22.0% 22.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Nov 10 '23 23:11 sonarqubecloud[bot]

Quality gate seems to be complaining about the tests having duplication...

blimmer avatar Nov 11 '23 00:11 blimmer

Hey @aripalo - any chance we can get this reviewed? If this isn't the direction you want to go with this repo, I might fork and publish a separate package. TYIA for your time and this great project!

blimmer avatar Jan 19 '24 17:01 blimmer