Ari Kornfeld

Results 53 comments of Ari Kornfeld

webpack output is not treated as a module (`import.meta`)

Thank you @alexander-akait and @hai-x, again for your help! Everything is working...almost! I've disabled `importMeta`, enabled module output, and set `devtool` to `false` or `source-map`, and ended up having to...

webpack output is not treated as a module (`import.meta`)

@alexander-akait I can try. Meanwhile, here's [my fork with the buggy behavior](https://github.com/arikorn/companion/tree/fix_Windows_build_in_WSL). `yarn dist` should run the webpack build and put the packaged code into electron-output/xxx-unpacked, where xxx is the...

webpack output is not treated as a module (`import.meta`)

A partial update: creating a small test repo is probably not trivial -- my first attempt to isolate the offending code was not successful, i.e. the isolated code worked fine....

webpack output is not treated as a module (`import.meta`)

@hai-x you are beyond awesome! Your proposed fix appears to work. I've commented further in the PR. Looking at your code, is that an actual fix or just a diagnostic...

webpack output is not treated as a module (`import.meta`)

@hai-x: taking a cue from your PR, I just disabled the `concatenateModules` optimization and everything is fine even with the current webpack release (5.102.1). What downside is there in skipping...

webpack output is not treated as a module (`import.meta`)

Thank you @hai-x for the extra detail. I'll look forward to the next release! Meanwhile, just to wrap up this issue... First of all, thank you @alexander-akait and @hai-x for...

webpack output is not treated as a module (`import.meta`)

Thank you @alexander-akait for the reply and reassurance! I am curious about your comment against disabling concatenateModules: could you elaborate? What harm would there be, particularly for a node app?...

webpack output is not treated as a module (`import.meta`)

Thank you Alexander that's great news: I will look forward to the release. FWIW, I compared packs with and without `concatenateModules` enabled. The code size was almost identical, but the...

webpack output is not treated as a module (`import.meta`)

@alexander-akait , well Companion definitely uses ES modules -- that's the topic of this issue! Don't know about special -- here's the [package.json](https://github.com/bitfocus/companion/blob/main/companion/package.json) that webpack sees if you want to...

[BUG] Inconsistent handling of template variables in button text expressions

The following are comments from @Julusian in the above-reference PR, as the pertain to the remaining issue (much of the following, I believe, is referring to my suggestion that ``...