vanilla-nested icon indicating copy to clipboard operation
vanilla-nested copied to clipboard

the links are not present in the tabbing order

Open yshmarov opened this issue 3 years ago • 2 comments

something like tabindex="0" should be added to the links so that they can be Tab-bed to. Will add more on this later

@yshmarov

<a role="button" tabindex="0" ...>...

yshmarov avatar Sep 03 '21 12:09 yshmarov

hey @yshmarov thanks for the report, I think this other issue would cover that https://github.com/arielj/vanilla-nested/issues/31, I was thinking about having one more html_attribute hash argument in the link_to_add/remove_nested helpers that can be used to set the HTML attributes of the generated tag, that way we can add role, tabindex, alt, title, etc for the users that need it

Do you think that would cover this feature requrest too?

arielj avatar Sep 03 '21 12:09 arielj

@yshmarov I released version 1.4.0 today, I think it may fix this issue but maybe the tabindex is a more complex use case (all link_to_remove_nested will have the same tabindex for example) but you can now add role and tabindex attributes

arielj avatar Sep 22 '21 03:09 arielj