ionic-pullup icon indicating copy to clipboard operation
ionic-pullup copied to clipboard

Pullup over navbar

Open AdrienDC opened this issue 8 years ago • 14 comments

Hello, I recently updated my iphone and I got an issue I didn't have before on IOS 9.3.2. When I tap on the pullup item it goes beyond where it supposed to go, see the screenshot.

It's happening only on IOS, not Android though... Shall I play with max-height for a workaround?

Thanks ! img_9667

AdrienDC avatar Sep 06 '16 11:09 AdrienDC

@AdrienDC I think you are the first one to report this. Are you still having issues? I wonder if anybody else has experienced this. Seems to work well on my end.

arielfaur avatar Sep 12 '16 21:09 arielfaur

Had some similar problem once, because my layout uses a double header line. Ended adding an overrrideBottom attribute and setting a fixed value for CSS bottom when required. A not-so-nice solution.

jsanta avatar Sep 12 '16 21:09 jsanta

Hello @arielfaur , yes still got the problem.. It's like the height of the status bar is not included because I've tried to manually input and I got the same result: footer.height = footer.maxHeight > 0 ? footer.maxHeight : $window.innerHeight - 93 - 25

Corresponding to the window height minus tabs height and header height.

AdrienDC avatar Sep 21 '16 04:09 AdrienDC

I wonder if that happens without tabs. @jsanta did your template have bottom tabs too?

arielfaur avatar Sep 21 '16 15:09 arielfaur

Yes, one of my views has bottom-tabs. The last time I messed with the code I noticed there was a slight problem with the active view selector in the plugin, haven't seen the updated version.

jsanta avatar Sep 21 '16 15:09 jsanta

Just a thought, are you using StatusBar plugin? I was wondering if StatusBar.overlaysWebView(false); has any effect.

AdrienDC avatar Sep 21 '16 19:09 AdrienDC

So this bug seems to appear only when adding tabs to a template. I am not certain it makes sense at all to have a pullup together with tabs. Both Android and iOS have bottom tabs by default as of the latest version and I am not sure it is a valid use case in terms of usability to show a footer above the tabs. What do you think?

arielfaur avatar Sep 21 '16 21:09 arielfaur

Bad news.. I think it still make sense to use it with tabs because you may want to display something temporary, for example notifications.. And it shouldn't be above tabs indeed, it should stop when reaching the tabs bar.

AdrienDC avatar Sep 21 '16 22:09 AdrienDC

I had to remove 20 pixels to get it right for iOS

AdrienDC avatar Sep 27 '16 02:09 AdrienDC

Now it seems to be corrected in iOS 10...

AdrienDC avatar Oct 01 '16 02:10 AdrienDC

I am now focused on Ionic 2 and will stop any further development of this plugin for Ionic 1 due to lack of time. With Ionic 2 everything seems to run smoother!

arielfaur avatar Oct 02 '16 00:10 arielfaur

Hi! I think there is mistake in ion-pullup.scss file.

scroll-content {
          margin-bottom: calc(#{$toolbar-ios-height} + #{$tabHeight});
        }

should be

.scroll-content {
          margin-bottom: calc(#{$toolbar-ios-height} + #{$tabHeight});
        }

since scroll-content is a class in div element, not an element himslef. Hope that will help.

ipleh avatar Dec 02 '16 09:12 ipleh

@ipleh This thread is for the Ionic 1 version. I think you refer to Ionic 2, right?

arielfaur avatar Dec 14 '16 22:12 arielfaur

Right, sorry for that.

ipleh avatar Dec 15 '16 07:12 ipleh