Alberto Ricart

aleph build doesn't honor deno.json target

1

Doing a build to try to bypass the CORS issue, seems to fail: ```Download https://deno.land/x/[email protected]/commands/upgrade.ts Looking up latest version... Already up-to-date! > aleph build > .aleph/production/lib/billingclient.bundling.js:3142:4: error: Transforming async generator...

`max_bytes` consumer configurations perhaps shouldn't be smaller than it's streams `max_msg_size`

14

## Defect On a pull subscriber, it is now possible to request the maximum number of bytes to be handed on the request. Currently, this feature will reject sending messages...

This is currently only affecting internally - as nsc doesn't expose tier limit configuration. If you have an account with regular jetstream: ```javascript "mem_storage": 0, "disk_storage": 5 * GB, ```...

`max_batch` and `max_expires` are only meaningful to pull consumers, they can be set and updated on push consumers without a server rejection. `inactive_threshold` is only meaningful for ephemeral consumers, but...

on JetStream ack timeout, ack_pending is expected to be decreased and num_pending to be increased

5

On ack expiration, the ack_pending is not getting decreased, and num_pending is not getting re-increased. ```typescript Deno.test("manual - pull inflight acks expired", async () => { const sc = StringCodec();...

JSON encoded connection doesn't report error on bad JSON

5

If a non-json client publishes a message that is invalid JSON, an encoded connection doesn't report the issue, this tests demonstrates the issue: ```go func TestJSONBad(t *testing.T) { var d...

The readme page shows usage that won't work if an user tries it out

5

See https://github.com/nats-io/nats.js/issues/344 While the API is shown correctly, the ordering is not. So copy-paste will not result in what the user may be expecting by reading the sample code illustrating...

multiple response requests `Stream`, `Chunked` should be one 'Multiple'

5

The concept of `Stream`, `Chunked`, `Singleton` has some clarification - singleton is obviated, as that is the standard pattern. `Chunked` is intended for segmenting a large piece of data into...

subject rewriting responses are handled incorrectly

1

https://github.com/nats-io/nats.go/blob/b1f0d197532c7f1e578b96c3a510275b2ea3e800/nats.go#L2652 If there's a response mux, services that re-write responses won't be able to parse the response subject to dispatch to the mux subscription. Currently, if there's only one mux...