Ismael Arias

Results 23 comments of Ismael Arias

@prologic @andrewkroh Done! Let me know if anything still needs some work.

Didn't even think about Windows now that I see the tests failing to be honest. @andrewkroh If I'm not mistaken, the only thing that I should do is just implement...

I just added a commit to the PR, adding the missing functions on Windows and AIX hosts. Also, I updated the README as well to note the new `LoadAverage` interface...

@andrewkroh What's the status of this? Just asking to know if there's anything left I should do on my side.

You can simply change the default terminal used by Nemo, so the `Open in Terminal` option will open Tilix: `gsettings set org.cinnamon.desktop.default-applications.terminal exec /usr/bin/terminator` See [https://askubuntu.com/a/1262762](https://askubuntu.com/a/1262762)

Couple of things: - Having a hard time trying to understand how to build the tests (I'm guessing that it should be a test case in [here](https://github.com/grafana/k6/blob/master/internal/js/modules/k6/grpc/client_test.go#L40)). I just checked...

Hey @mstoykov, thanks a lot for the review! I’ve made some changes based on your comments. There’s one part I didn't change yet because I’m not fully sure I understand...

Hi there, sorry for the delay on this! It's been a while since I could get back to this PR (I haven't had much time recently). I've made the requested...

Hi @joanlopez, Thank you for catching that one! I implemented a fix by following what's done in the `stringify` method in Sobek, and added a test case as well: https://github.com/grafana/k6/blob/602467dee735ba74fc9664b23ca53220f1212f0c/vendor/github.com/grafana/sobek/builtin_json.go#L366-L372...

Hi! I was looking into this since I have the same problem. First, I wanted to understand why a null value works for the single float but not for the...