Arhik comments

Results 51 comments of


                                            Arhik

error hint for getproperty(::Dict, ::Symbol)

@LilithHafner I raised another PR https://github.com/JuliaSparse/SparseArrays.jl/pull/539 related to this. How do we resolve this dependency. We need SparseArrays PR to be accepted for julia tests to pass. ref (https://buildkite.com/julialang/julia-master/builds/36697#018fa506-1c87-42bf-b902-09ef3cb581ec/826-1173)

error hint for getproperty(::Dict, ::Symbol)

Understood the concern. I didn't get chance to look into it. I will try make time soon.

error hint for getproperty(::Dict, ::Symbol)

@LilithHafner The `type` information is lost even before it comes to `jl_new_struct`. On inspection found issue in `codegen`. We didn't make corresponding changes in llvm related emit function signatures. @gbaraldi...

error hint for getproperty(::Dict, ::Symbol)

@LilithHafner I rebased code. Can you check and validate whenever you are free ?

error hint for getproperty(::Dict, ::Symbol)

@LilithHafner I started a small discussion on error hints. I see a potential issue. It can be separate issue and PR but posting it here for book keeping for others...

error hint for getproperty(::Dict, ::Symbol)

> Just to come in here at the 11th hour with a bit of greediness, could > > ```julia > struct FieldError type::DataType > field::Symbol > end > ``` >...

error hint for getproperty(::Dict, ::Symbol)

Quickly tried this and pasting this. Let me know if this is what you are implying. (overhead version obviously) ```julia struct PropertyError

[LinearAlgebra] zero(::ArrayWrapper) is forwarded to the parent

Duplicate of original PR - JuliaLang/julia#53449 with some minor changes. Want to know what's stopping this.

[LinearAlgebra] zero(::ArrayWrapper) is forwarded to the parent

@jishnub any comments on this PR.

[LinearAlgebra] zero(::ArrayWrapper) is forwarded to the parent

> I think the argument earlier was that this might degrade performance for strided matrices with `uplo` defined? In that case, we may want to loop over only one triangular...