open-props
open-props copied to clipboard
argyleink
Light and dark normalize surface colors enhancement
this would be a breaking change:
surface 1-4 behave slightly different between the light and dark themes. it'd be nice if they behaved the same, in that surface 1 is the lightest and surface 4 is the darkest (like how the color palettes work).
todo: explain this better and create a demo example reproducing the issue (like cards sitting on the body)
I think of surfaces 1 to 4 like layers of various altitudes, not as color shades. So, the current naming makes sense for me. I think I would be confused if they behaved the same as suggested here. As surface-1, the low altitude surface would become surface-4 in dark mode. Or am I misunderstanding the issue here ?
i like to think of them in altitudes as well, but i dont think it's hit the mark yet with the current setup. but sounds like you havent run into the issue?! that's nice, i mean, it's not super common for me to, but does have some edges that i'd like to polish.
i've got a codepen i hack on at night sometimes, trying to get my thoughts down ,but it's not quite ready to share. thanks for chimin in!
I ran into this as well. To me it makes the most sense to have the lower numbers lighter in both cases.
As it is currently, cards that are lighter than their background in light mode (e.g. surface-1 on the cards with surface-2 behind them) become darker than their background in dark mode, which looks weird to me (because light comes from the sky).
(Open Props is fantastic, btw!)
