gui-challenges icon indicating copy to clipboard operation
gui-challenges copied to clipboard

consider removing the RTL flip

Open argyleink opened this issue 3 years ago • 6 comments

Mohammed Ali Agha commented the change is understood but not needed as they've already adjusted

argyleink avatar Aug 11 '21 20:08 argyleink

Basic question at the end: If people are used to broken designs/behaviour (which may be formally incorrect), should we fix it anyways? I'm unsure if there is a definitive answer in this case at all because it may be very depending on who you ask...

The same topic is discussed here https://www.youtube.com/watch?v=OHF2h1_fBCM and I'm quite unsure about this for myself - but would be interested in more input on this.

benbender avatar Aug 12 '21 07:08 benbender

great link and thoughts, thanks!

argyleink avatar Aug 16 '21 17:08 argyleink

any progress, to fix it?

X7md avatar Oct 24 '22 18:10 X7md

Sidenav don't support RTL https://github.com/argyleink/gui-challenges/tree/main/sidenav

X7md avatar Oct 24 '22 20:10 X7md

not clear in this issue, but yeah, it's attached to the Switch component.

argyleink avatar Oct 24 '22 21:10 argyleink

I don't think there is a real issue here, and this can be closed. I have opened the switch component to fix it, but watching the video and interacting with the component in the local environment, you have taken the right approach.

aria-pressed= true state showing aria-pressed

aria-pressed= false state showing aria-pressed-false


aria-pressed= true on the iPhone

showing aria-pressed on iPhone

aria-pressed= false on the iPhone

showing aria-pressed-false on iPhone

Sboonny avatar Jan 14 '23 16:01 Sboonny