Ferret icon indicating copy to clipboard operation
Ferret copied to clipboard

Various

Open akavel opened this issue 12 years ago • 0 comments

Please, add info on average & worst complexity in godoc comments for each function.

Also, in godoc comments for "Insert" function, you refer to "MakeInvertedSuffix", which is not present - supposedly that was an old name and you mean the "New" function?

Also, you have lots of deeply nested ifs in your code - you could consider using 'continue' in ifs in loops, to ease reading.

Also, you have quite a few exact repetitions of big chunks of code, I strongly advise to seriously consider extracting them to functions, or please at least comment if that's as is because of Serious Optimizations Totally Backed By Measurements And Not Premature, otherwise (paired with the issue above) they make reading the codebase highly tedious and irritating.

thanks.

akavel avatar Aug 29 '13 20:08 akavel