notifications-engine
notifications-engine copied to clipboard
argoproj
Update aws-sdk-go-v2 for EKS Pod Identities
Update aws-sdk-go-v2 to support EKS Pod Identities
Will update the indirect in https://github.com/argoproj/argo-cd/pull/16641
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c02dc5f) 55.13% compared to head (6cb32f9) 55.19%.
Additional details and impacted files
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 55.13% 55.19% +0.05%
==========================================
Files 35 35
Lines 3337 3339 +2
==========================================
+ Hits 1840 1843 +3
+ Misses 1230 1229 -1
Partials 267 267
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Was testing this patch and sqs notifications are failing
time="2024-01-21T04:50:06Z" level=error msg="Got an error getting the queue URL: not found, ResolveEndpointV2"
time="2024-01-21T04:50:06Z" level=error msg="Failed to notify recipient {awssqs ArgoCDNotifications} defined in resource argocd/workload-dev: not found, ResolveEndpointV2 using the configuration in namespace argocd" resource=argocd/workload-dev
I tried with and without specifying account/region/endpointUrl
It looks like there is a problem with the sdk version, we might need to update more components to latest like aws-sdk-go-v2/service/sqs
I found this issue https://github.com/aws/aws-sdk-go-v2/issues/2370
@ROunofF I sent you a PR to fix the sqs issue, I tested and it works https://github.com/ROunofF/notifications-engine/pull/1