notifications-engine icon indicating copy to clipboard operation
notifications-engine copied to clipboard
verified publisher icon argoproj

feat: add gitlab service

Open aslafy-z opened this issue 2 years ago • 3 comments

Fixes https://github.com/argoproj/notifications-engine/issues/137

TODO:

  • Add tests for repo name to PID compute
  • Figure out how to reuse existing deployments (Do something like https://github.com/argoproj/notifications-engine/pull/235?)
  • Option: Assumption: The referenced Environment is managed by ArgoCD notifications. Any updates will create a new deployment res.
  • Add option to delete that stop the environment.
  • Find the max length for commit statuses descriptions
  • Write documentation
  • Reduce code for templated fields (like https://github.com/argoproj/notifications-engine/pull/223?)

aslafy-z avatar Nov 03 '23 18:11 aslafy-z

Hey @aslafy-z Thanks for wrapping up this PR. I was wondering if you're still working on it.

barryib avatar Jan 29 '25 21:01 barryib

@barryib I’ve moved to a new job and no longer have access to the GitLab instance. You can take over this PR. Let me know if you need any context. Thanks!

aslafy-z avatar Feb 19 '25 12:02 aslafy-z

Sure. I'll have a look over the week. Thanks for letting us know.

barryib avatar Feb 19 '25 13:02 barryib