notifications-engine icon indicating copy to clipboard operation
notifications-engine copied to clipboard

feat: support SkipFirstRun service

Open ryota-sakamoto opened this issue 4 years ago • 2 comments

Signed-off-by: Ryota Sakamoto [email protected]

refs: argoproj-labs/argocd-notifications#210

ryota-sakamoto avatar May 11 '21 18:05 ryota-sakamoto

Sorry for delay, still catching up after vacation.

alexmt avatar May 22 '21 02:05 alexmt

Codecov Report

Merging #18 (3b6250a) into master (43c9003) will decrease coverage by 0.64%. The diff coverage is 86.48%.

:exclamation: Current head 3b6250a differs from pull request most recent head e2c5a81. Consider uploading reports for the commit e2c5a81 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   47.51%   46.87%   -0.65%     
==========================================
  Files          29       26       -3     
  Lines        1671     1504     -167     
==========================================
- Hits          794      705      -89     
+ Misses        698      645      -53     
+ Partials      179      154      -25     
Impacted Files Coverage Δ
pkg/controller/state.go 88.13% <84.37%> (+0.04%) :arrow_up:
pkg/controller/controller.go 54.61% <100.00%> (-0.95%) :arrow_down:
pkg/cmd/context.go 43.03% <0.00%> (-2.09%) :arrow_down:
pkg/services/googlechat.go
pkg/services/pushover.go
pkg/services/alertmanager.go
pkg/services/services.go 23.63% <0.00%> (+0.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43c9003...e2c5a81. Read the comment docs.

codecov[bot] avatar Aug 18 '21 15:08 codecov[bot]