notifications-engine
notifications-engine copied to clipboard
feat: allow configuration of repoUrl and revision (#59)
First PR here. Do you mind to let me know what's required to move this forward?
Signed-off-by: Till Backhaus [email protected]
Codecov Report
Base: 49.21% // Head: 49.91% // Increases project coverage by +0.70%
:tada:
Coverage data is based on head (
82fe901
) compared to base (b605032
). Patch coverage: 51.11% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 49.21% 49.91% +0.70%
==========================================
Files 31 31
Lines 1855 1855
==========================================
+ Hits 913 926 +13
+ Misses 743 736 -7
+ Partials 199 193 -6
Impacted Files | Coverage Δ | |
---|---|---|
pkg/services/github.go | 37.23% <51.11%> (+11.70%) |
:arrow_up: |
pkg/services/services.go | 25.00% <0.00%> (+1.47%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
How to define a custom revision? Define a static revision as annotation may a bit pointless.
Solved already in https://github.com/argoproj/notifications-engine/pull/115 , Thank you for effort that you did!