gitops-engine

gitops-engine copied to clipboard

My preference is to capitalize the first letter and omit the trailing `...` https://github.com/argoproj/gitops-engine/blob/cc707ccc94eca610ae467de38c92d33835bc7b55/pkg/health/health_statefulset.go#L46-L48 https://github.com/argoproj/gitops-engine/blob/cc707ccc94eca610ae467de38c92d33835bc7b55/pkg/health/health_statefulset.go#L67-L69 https://github.com/argoproj/gitops-engine/blob/cc707ccc94eca610ae467de38c92d33835bc7b55/pkg/health/health_statefulset.go#L72-L75 https://github.com/argoproj/gitops-engine/blob/cc707ccc94eca610ae467de38c92d33835bc7b55/pkg/health/health_statefulset.go#L84-L86 https://github.com/argoproj/gitops-engine/blob/cc707ccc94eca610ae467de38c92d33835bc7b55/pkg/health/health_statefulset.go#L119-L121

jsoref

This issue is to ask about how one might manage the health check of a CRD. Maybe ArgoRollouts would provide a good example?

ghostsquad

feat: local crd validation

6

CRDs from Kubernetes version 1.15 support a field `x-kubernetes-preserve-unknown-fields` that affects validation when a CRD introduces a new field and a CR in the same sync defines a value for...

pepov

feature: add methods to get annotations

2

Signed-off-by: darshanime required for https://github.com/argoproj/argo-cd/pull/4123

darshanime

- Temporary files are not always deleted - Temporary files are not always closed

ash2k

clusterCache.IsNamespaced() lacks locking

1

`c.namespacedResources` is a field that can be mutated concurrently so access must be protected with locking.

ash2k

feat: explicitly specify watch timeout for resClient.Watch

4

If we are not set the watch timeout param on the client side, the k8s apiserver will use the default server timeout param. ArgoCD will re-list frequently when the server...

sheeponmeth

# Summary After the reflection-based conversion was deprecated in K8S v1.19 the health assessment contains a lot of duplicated code ( see https://github.com/argoproj/gitops-engine/pull/139 ). We should consider using `unstructured` package...

alexmt

pod stuck in Terminating state if DeletePropagationForeground

1

https://github.com/kubernetes/kubernetes/issues/65569 Could we use delete propagation background as default propagation policy I met the issue above

runzexia

Required permissions are too broad and not configurable

2

Currently gitops engine gets the list of api resources and starts watches for all of them that support list+watch verbs. This means a program, using the gitops engine, needs permissions...

ash2k