gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

fix: Update checkPermissions to not exit the namespace loop after the first namespace regardless

Open andrii-korotkov opened this issue 3 months ago • 2 comments

Helps with https://github.com/argoproj/argo-cd/issues/23855

The namespace loop would be exited after the first namespace in all cases, which is wrong. The correct thing to do seems to only return false after all namespaces were checked and none resulted in true.

andrii-korotkov avatar Sep 18 '25 06:09 andrii-korotkov

Codecov Report

:x: Patch coverage is 0% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.39%. Comparing base (8849c3f) to head (60ff409). :warning: Report is 62 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cache/cluster.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
- Coverage   54.26%   47.39%   -6.87%     
==========================================
  Files          64       64              
  Lines        6164     6589     +425     
==========================================
- Hits         3345     3123     -222     
- Misses       2549     3209     +660     
+ Partials      270      257      -13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 18 '25 06:09 codecov[bot]