gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

fix: when case isSuspended, should assign Message: message, not failMsg

Open LinPr opened this issue 5 months ago • 2 comments

	failed := false
	var failMsg string
	complete := false
	var message string
	isSuspended := false
	for _, condition := range job.Status.Conditions {
		switch condition.Type {
		case batchv1.JobFailed:
			failed = true
			complete = true
			failMsg = condition.Message
		case batchv1.JobComplete:
			complete = true
			message = condition.Message
		case batchv1.JobSuspended:
			complete = true
			message = condition.Message
			if condition.Status == corev1.ConditionTrue {
				isSuspended = true
			}
		}
	}
	switch {
	case !complete:
		return &HealthStatus{
			Status:  HealthStatusProgressing,
			Message: message,
		}, nil
	case failed:
		return &HealthStatus{
			Status:  HealthStatusDegraded,
			Message: failMsg,
		}, nil
	case isSuspended:
		return &HealthStatus{
			Status:  HealthStatusSuspended,
			Message: message,
		}, nil
	default:
		return &HealthStatus{
			Status:  HealthStatusHealthy,
			Message: message,
		}, nil
	}

we can see when isSuspended = true, the message = condition.Message was executed, so the under case should be

case isSuspended:
    return &HealthStatus{
	    Status:  HealthStatusSuspended,
	    Message: message,
    }, nil

LinPr avatar Jul 30 '25 11:07 LinPr

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.22%. Comparing base (8849c3f) to head (5be3057). :warning: Report is 55 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
- Coverage   54.26%   47.22%   -7.05%     
==========================================
  Files          64       64              
  Lines        6164     6529     +365     
==========================================
- Hits         3345     3083     -262     
- Misses       2549     3191     +642     
+ Partials      270      255      -15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 30 '25 11:07 codecov[bot]