gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

feat: add Prune as application level sync option

Open MrFreezeex opened this issue 7 months ago • 4 comments

Related to https://github.com/argoproj/argo-cd/pull/23370 / https://github.com/argoproj/argo-cd/issues/23380

MrFreezeex avatar Jun 12 '25 14:06 MrFreezeex

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 47.54%. Comparing base (8849c3f) to head (a1d18d9). Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
pkg/sync/sync_context.go 20.00% 8 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   54.26%   47.54%   -6.73%     
==========================================
  Files          64       64              
  Lines        6164     6575     +411     
==========================================
- Hits         3345     3126     -219     
- Misses       2549     3193     +644     
+ Partials      270      256      -14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 16 '25 10:06 codecov[bot]

(note that I only changed the second commit title that was point at the wrong sync option before :x)

MrFreezeex avatar Jun 16 '25 11:06 MrFreezeex

code LGTM. Missing unit test and waiting for answers in the linked argo CD PR

Thanks @agaudreault! I added some unit test for Prune=false and Prune=confirm, the latter didn't had any so far so I added some for Prune=confirm on a resource directly too

MrFreezeex avatar Jun 18 '25 09:06 MrFreezeex