fix(sync): create namespace before dry-run
Replaces https://github.com/argoproj/gitops-engine/pull/708 reverted by https://github.com/argoproj/gitops-engine/pull/730 Fixes https://github.com/argoproj/argo-cd/issues/21788
Tested in Argo CD by https://github.com/argoproj/argo-cd/pull/23304
Codecov Report
Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.
Project coverage is 53.75%. Comparing base (
8849c3f) to head (a3a3fb4). Report is 51 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/sync/sync_context.go | 78.26% | 3 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
- Coverage 54.26% 53.75% -0.51%
==========================================
Files 64 64
Lines 6164 6531 +367
==========================================
+ Hits 3345 3511 +166
- Misses 2549 2743 +194
- Partials 270 277 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@crenshaw-dev tested in https://github.com/argoproj/argo-cd/pull/23304 and user confirmed the fix is good https://github.com/argoproj/argo-cd/issues/21788#issuecomment-2949821445