gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

Do not use `--force` with `--dry-run`

Open rafal-jan opened this issue 1 year ago • 3 comments

Closes https://github.com/argoproj/gitops-engine/issues/623.

Currently the same value of force parameter is passed when performing dry-run of a resource and actually creating it on the cluster. This causes issues when using Force=true with sync waves.

rafal-jan avatar Nov 04 '24 18:11 rafal-jan

Codecov Report

:x: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.52%. Comparing base (8849c3f) to head (c349708). :warning: Report is 56 commits behind head on master.

Files with missing lines Patch % Lines
pkg/utils/kube/resource_ops.go 0.00% 7 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   54.26%   53.52%   -0.74%     
==========================================
  Files          64       64              
  Lines        6164     6520     +356     
==========================================
+ Hits         3345     3490     +145     
- Misses       2549     2753     +204     
- Partials      270      277       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 06 '25 17:06 codecov[bot]