Bug: kubeCmdFactory will lose WrapTransport config

Open a244591052 opened this issue 1 year ago • 0 comments

https://github.com/argoproj/gitops-engine/blob/95e00254f82a1e2a38c47b8383e68dddff763b88/pkg/utils/kube/resource_ops.go#L150-L160

In the above code, WrapTransport is not passed, which will cause the client corresponding to the NewFactory to have no WrapTransport, which is not as expected.

In addition, RateLimiter is not passed, which will cause the NewFactory client to create a new RateLimiter using the passed in QPS. If k8s is limiting the flow for the client, then it is expected. If k8s is limiting the flow for the IP address, then RateLimiter should be passed.

fix pr: https://github.com/argoproj/gitops-engine/pull/622

Aug 25 '24 04:08 a244591052