gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

Published 20 hours ago • verified publisher icon argoproj

Bump Kubernetes 1.29.2

Open sivchari opened this issue 4 months ago • 9 comments

This PR aims to updating Kubernetes version to 1.29.1

sivchari avatar Feb 28 '24 13:02 sivchari

Codecov Report

Attention: Patch coverage is 54.83871% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 55.25%. Comparing base (5fd9f44) to head (99b2b78). Report is 3 commits behind head on master.

:exclamation: Current head 99b2b78 differs from pull request most recent head d086c31. Consider uploading reports for the commit d086c31 to get more accurate results

Files Patch % Lines
pkg/utils/kube/resource_ops.go 0.00% 11 Missing :warning:
pkg/sync/sync_context.go 88.23% 2 Missing :warning:
pkg/utils/kube/kube.go 0.00% 1 Missing :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   54.71%   55.25%   +0.54%     
==========================================
  Files          41       41              
  Lines        4834     4821      -13     
==========================================
+ Hits         2645     2664      +19     
+ Misses       1977     1945      -32     
  Partials      212      212

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 28 '24 14:02 codecov[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] avatar Mar 12 '24 22:03 sonarcloud[bot]

Hi @leoluz. Could you review it ? Thanks.

sivchari avatar Apr 05 '24 02:04 sivchari

Hi, @pasha-codefresh . Could you review this PR ? Thanks.

sivchari avatar Apr 17 '24 04:04 sivchari

@sivchari are you still up for working on this? I have some time to help.

crenshaw-dev avatar Apr 23 '24 17:04 crenshaw-dev

Hi, @crenshaw-dev

I've finished it, so could you check these changes ?

sivchari avatar Apr 24 '24 08:04 sivchari

@sivchari took a quick glance through, and it's looking good. Would you mind opening an Argo CD PR pointing at your gitops-engine fork so we can run those tests as well? Here's an example of how that looks: https://github.com/argoproj/argo-cd/pull/16967/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R296

crenshaw-dev avatar Apr 25 '24 17:04 crenshaw-dev

Hi @crenshaw-dev I'm sorry that I was late. Thank you for watching my changes.

I've already opened the PR in ArgoCD. The following link is it and the only thing that I should do is to pass the CI. So, if this PR is ready to be merged, I'd like to merge this PR into gitops-engine. https://github.com/argoproj/argo-cd/pull/17491

Thanks.

sivchari avatar May 01 '24 05:05 sivchari

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] avatar May 02 '24 07:05 sonarcloud[bot]