gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

feat: sync-options annotation with Force=true (#414)

Open kkk777-7 opened this issue 1 year ago • 3 comments

This PR implements #414, https://github.com/argoproj/argo-cd/issues/5882

Changes:

  • Add new annotation argocd.argoproj.io/sync-options: Force=true

Related: https://github.com/argoproj/gitops-engine/pull/526

kkk777-7 avatar Dec 09 '23 09:12 kkk777-7

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.66%. Comparing base (5fd9f44) to head (bba3871). Report is 2 commits behind head on master.

:exclamation: Current head bba3871 differs from pull request most recent head a463a21. Consider uploading reports for the commit a463a21 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
- Coverage   54.71%   54.66%   -0.05%     
==========================================
  Files          41       41              
  Lines        4834     4648     -186     
==========================================
- Hits         2645     2541     -104     
+ Misses       1977     1910      -67     
+ Partials      212      197      -15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 09 '23 09:12 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
27.5% 27.5% Duplication

sonarqubecloud[bot] avatar Dec 09 '23 09:12 sonarqubecloud[bot]

Any chance this can get merged soon?

jmgilman avatar Jan 18 '24 18:01 jmgilman

Also interested in seeing this merged

douglasday avatar Feb 13 '24 21:02 douglasday

It's now been almost two years since we're waiting for that fix ( https://github.com/argoproj/gitops-engine/issues/414 ) Is there anyone to review that PR?!

@alexec @alexmt @jannfis @jessesuen @mayzhang2000 ?

faust64 avatar Feb 19 '24 07:02 faust64

@kkk777-7 , i am really sorry for long review on it, could you please solve conflicts ?

pasha-codefresh avatar Apr 16 '24 11:04 pasha-codefresh

@pasha-codefresh , thank you reply! I resolved conflict.

kkk777-7 avatar Apr 16 '24 12:04 kkk777-7