gitops-engine
gitops-engine copied to clipboard
feat: sync-options annotation with Force=true (#414)
This PR implements #414, https://github.com/argoproj/argo-cd/issues/5882
Changes:
- Add new annotation
argocd.argoproj.io/sync-options: Force=true
Related: https://github.com/argoproj/gitops-engine/pull/526
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 54.66%. Comparing base (
5fd9f44
) to head (bba3871
). Report is 2 commits behind head on master.
:exclamation: Current head bba3871 differs from pull request most recent head a463a21. Consider uploading reports for the commit a463a21 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
- Coverage 54.71% 54.66% -0.05%
==========================================
Files 41 41
Lines 4834 4648 -186
==========================================
- Hits 2645 2541 -104
+ Misses 1977 1910 -67
+ Partials 212 197 -15
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells
No Coverage information
27.5% Duplication
Any chance this can get merged soon?
Also interested in seeing this merged
It's now been almost two years since we're waiting for that fix ( https://github.com/argoproj/gitops-engine/issues/414 ) Is there anyone to review that PR?!
@alexec @alexmt @jannfis @jessesuen @mayzhang2000 ?
@kkk777-7 , i am really sorry for long review on it, could you please solve conflicts ?
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
4.5% Duplication on New Code
@pasha-codefresh , thank you reply! I resolved conflict.