gitops-engine
gitops-engine copied to clipboard
argoproj
Update condition to select right pvc as child for statefulset
We have 2 pvc in namespace, one with name emqx-data-sw-broker-0 for statefulset sw-broker and other one is emqx-data-sw-broker-internal-0 for statefulset sw-broker-internal and both have same template name emqx-data. since emqx-data-sw-broker-internal-0 contains prefix emqx-data-sw-broker-, it consider it as part of sw-broker statefulset which is not right. fixing condition to check if it contains number at the end of prefix
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Any updates on this, I've experienced this issue as well and it would be nice to get it resolved.
any update on this? It's a bug fix and its been open for over 4 months
@hanzala1234 thank you for your contribution.
Could you please cover your changes with tests and also could you please add example yamls so i can test the fix locally?
i know @hanzala1234 did the work along with my company, I can try to take a look at that. I should have time this week (I'm gonna be traveling tomorrow).
I've had a few fires pop up this week, so it will probably be a week or 2 til I have time to look into this.
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
See analysis details on SonarCloud
Hello @pasha-codefresh We have added some test cases/examples into the code, it is good to review now
@nerdeveloper will review it tomorrow, sorry, didnt notice your msg
@hanzala1234 , thank you for your contribution, feel free to open ArgoCD PR with gitops-engine version update, you can assign or tag me, i will review it