gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

feat: Expose validation webhook warnings in Argo CD UI

Open Mattes83 opened this issue 9 months ago • 3 comments

This is a follow up of #493

I tried to implement the proposals of @crenshaw-dev

What do you think?

Mattes83 avatar Oct 11 '23 09:10 Mattes83

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Oct 11 '23 09:10 sonarcloud[bot]

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a00ce82) 54.60% compared to head (40e9453) 54.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   54.60%   54.40%   -0.20%     
==========================================
  Files          41       41              
  Lines        4641     4661      +20     
==========================================
+ Hits         2534     2536       +2     
- Misses       1911     1927      +16     
- Partials      196      198       +2     
Files Coverage Δ
pkg/sync/common/types.go 50.00% <0.00%> (-4.17%) :arrow_down:
pkg/sync/sync_context.go 72.83% <20.00%> (-1.25%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 11 '23 09:10 codecov[bot]

This would be a great addition when using with operators that return some actual warnings.

cenk1cenk2 avatar May 13 '24 15:05 cenk1cenk2