gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

[email protected] incompatible with argo-cd/v2 v2.4.10

Open stb1337 opened this issue 2 years ago • 3 comments

I am writing an go lang app which uses argo-cd/v2 v2.4.10.

Therefore I have included github.com/argoproj/argo-cd/v2 v2.4.10 in my go.mod file and added all replace() https://github.com/argoproj/argo-cd/blob/master/go.mod#L255

but I keep getting this error:

go vet ./...
# github.com/argoproj/gitops-engine/pkg/utils/kube
../../pkg/mod/github.com/argoproj/[email protected]/pkg/utils/kube/resource_ops.go:270:38: not enough arguments in call to k.fact.Validator
	have (bool)
	want (string, *"k8s.io/cli-runtime/pkg/resource".QueryParamVerifier)
../../pkg/mod/github.com/argoproj/[email protected]/pkg/utils/kube/resource_ops.go:278:30: undefined: resource.NewDryRunVerifier
../../pkg/mod/github.com/argoproj/[email protected]/pkg/utils/kube/resource_ops.go:326:30: undefined: resource.NewDryRunVerifier
../../pkg/mod/github.com/argoproj/[email protected]/pkg/utils/kube/resource_ops.go:375:30: undefined: resource.NewDryRunVerifier

Solution was to add another replace(): github.com/argoproj/gitops-engine => github.com/argoproj/gitops-engine v0.7.1-0.20220804190909-2bc3fef13e07

Request: May you release another v0.7.2 or include the changes of v0.7.1-0.20220804190909-2bc3fef13e07 into the existing v0.7.1?

I hope I didn't make any rookie mistake,

Cheers, Steffen

stb1337 avatar Aug 18 '22 09:08 stb1337

@sTb1337 do you have some more context on this? I am seeing the same thing with argo-cd 2.5.0 and gitops-engine v0.7.3. Where does v0.7.1-0.20220804190909-2bc3fef13e07 originate from? Is there a PR somehwere that deals with it?

karlschriek avatar Oct 26 '22 12:10 karlschriek

Hey, I'm using Argocd package v2.5.6 and I also had to replace the gitops-engine to v0.7.1-0.20220804190909-2bc3fef13e07. Any Idea when this will be resolved?

RnkeZ avatar Jan 11 '23 16:01 RnkeZ

Trying to use the latest versions of argo-cd/v2 and rollouts also causes a similar build issue if the k8s.io Kubernetes packages are upgraded beyond 0.25.15.

It looks like something is strange with how gitops-engine works, as that is always the problem, and even locking it down to the versions mentioned here does not help.

skandragon avatar Dec 22 '23 18:12 skandragon