gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

Add the normalizer that makes use of well-known types

Open sbose78 opened this issue 4 years ago • 2 comments

  • [x] Tests successful
  • [ ] Generation of well-known types
  • [x] Does this break any API compatibility? probably not.
  • [x] Does this take care of exposing only those functions which are needed to expose? yes

partially https://github.com/argoproj/gitops-engine/issues/178

sbose78 avatar Mar 23 '21 17:03 sbose78

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
6.5% 6.5% Duplication

sonarqubecloud[bot] avatar Mar 24 '21 03:03 sonarqubecloud[bot]

Codecov Report

Merging #250 (ce1cc12) into master (89ddd0d) will increase coverage by 5.83%. The diff coverage is 95.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   49.87%   55.71%   +5.83%     
==========================================
  Files          40       43       +3     
  Lines        3186     3658     +472     
==========================================
+ Hits         1589     2038     +449     
- Misses       1437     1449      +12     
- Partials      160      171      +11     
Impacted Files Coverage Δ
pkg/diff/diff.go 62.57% <ø> (-0.22%) :arrow_down:
pkg/diff/normalizer.go 50.00% <50.00%> (ø)
pkg/diff/normalizer/knowntypes/normalizer.go 59.25% <59.25%> (ø)
pkg/diff/diff_options.go 83.33% <100.00%> (ø)
...g/diff/normalizer/knowntypes/corev1_known_types.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89ddd0d...ce1cc12. Read the comment docs.

codecov[bot] avatar Mar 24 '21 03:03 codecov[bot]