gitops-engine icon indicating copy to clipboard operation
gitops-engine copied to clipboard

kindOrder misses several Object Kinds later added in Helm

Open cobexer opened this issue 4 years ago • 1 comments

kindOrder references https://github.com/helm/helm/blob/master/pkg/tiller/kind_sorter.go which is now probably: https://github.com/helm/helm/blob/ab12382ddcd3a27a974b45ed96e47697de221244/pkg/releaseutil/kind_sorter.go#L31 which lists a few more Kind values as are currently listed in: https://github.com/argoproj/gitops-engine/blob/4eb3ca3feefbd6aa3cd800ef6a6ba396b8e70f05/pkg/sync/sync_tasks.go#L22

Looks like Argo needs to update the kindOrder to match Helm again!

cobexer avatar Jan 19 '21 13:01 cobexer

@alexmt This issue is fixed with PR https://github.com/argoproj/gitops-engine/pull/309, right?

brunokoeferli avatar Aug 04 '21 05:08 brunokoeferli