argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

add workflow labels to metrics?

Open linkingli opened this issue 2 years ago • 5 comments

Summary

add workflow labels to the metric?

Use Cases

When I have two workflowTemplates (A,B), I want to know the overall situation of workflow of A and B respectively. The current metric does not support me to do this. Since there is no label for workflow.

NOW:

argo_workflows_count{container="workflow-controller", endpoint="metrics", 
instance="127.0.0.1:9090", job="workflow-controller-metrics", namespace="argo",
 pod="workflow-controller-7d69c4b564-t6xn8",
 service="workflow-controller-metrics", status="Error"}

BETTER:

argo_workflows_count{container="workflow-controller", endpoint="metrics", 
instance="127.0.0.1:9090", job="workflow-controller-metrics", namespace="argo",
 pod="workflow-controller-7d69c4b564-t6xn8",
 service="workflow-controller-metrics", status="Error",labelName="LabelValue"}

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

linkingli avatar Oct 17 '22 09:10 linkingli