argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

fix(test): skip artifact private repo test. Fixes: #8953

Open ibotdotout opened this issue 2 years ago • 1 comments

Fixes #8953

~Introduced SKIP_PRIVATE_REPO environment variable to skip TestGitArtifactDriver_Load PrivateRepo test that some contributors lack of private repo access.~

Update test to skip TestGitArtifactDriver_Load PrivateRepo.


Please do not open a pull request until you have checked ALL of these:

  • [x] Create the PR as draft .
  • [x] Run make pre-commit -B to fix codegen and lint problems.
  • [x] Sign-off your commits (otherwise the DCO check will fail).
  • [x] Use a conventional commit message (otherwise the commit message check will fail).
  • [x] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • [x] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • [x] Github checks are green.
  • [x] Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

ibotdotout avatar Oct 16 '22 09:10 ibotdotout

There are already environment variables that controls this test

I see then how about just update document and git hook pre-commit message.

Let me know if you have another suggestion.

ibotdotout avatar Oct 17 '22 14:10 ibotdotout

Could you help to merge ? I rebased and pushed to re-trigger e2e that failed and the auto-merge is gone.

ibotdotout avatar Oct 31 '22 06:10 ibotdotout