argo-workflows
argo-workflows copied to clipboard
refactor: ui, convert cluster workflow template to functional component
Tested with UI
- loading cluster wf template
- no cluster wf template
- exist cluster wf template
Please do not open a pull request until you have checked ALL of these:
- [x] Create the PR as draft .
- [x] Run
make pre-commit -Bto fix codegen and lint problems. - [x] Sign-off your commits (otherwise the DCO check will fail).
- [x] Use a conventional commit message (otherwise the commit message check will fail).
- [ ] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
- [x] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
- [x] Github checks are green.
- [x] Once required tests have passed, mark your PR "Ready for review".
If changes were requested, and you've made them, dismiss the review to get it reviewed again.
added issue: https://github.com/argoproj/argo-workflows/issues/9810
The thought process goes like:
-
we have issue: https://github.com/argoproj/argo-workflows/issues/9772 https://github.com/argoproj/argo-workflows/issues/9627 To fix it we need to port the artifact visuliser from workflow detail to archive workflow detail.
-
But the 1 is written in functional component style the other is in class component. I'm thinking we'd better align the coding style first (refactor archived workflow to funcitonal component) workflow detail.tsx arvhiced workflow detail.tsx
-
But the archived workflow has quite some code to refactor. Thinking starting small, this cluster template is small
-
Also to expand the align on UI coding style, the new issue #9810. Also thinking we should refactor in batches/folder instead of all in one PR