argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

fix: Add --tls-certificate-secret-name parameter to server command. Fixes #5582

Open chtcvl opened this issue 3 years ago • 0 comments

Signed-off-by: vladimir.ivanov [email protected]

Fixes #5582

Add --tls-certificate-secret-name parameter to server command. Since server runs on localhost:2746, get an error in the UI "certificate is valid for ... not for localhost". Therefore the merge request set InsecureSkipVerify on TLSconfig for grpc client on the gateway.

Tested to to work with secret generated by cert-manager.

Please do not open a pull request until you have checked ALL of these:

  • [x] Create the PR as draft .
  • [x] Run make pre-commit -B to fix codegen and lint problems.
  • [x] Sign-off your commits (otherwise the DCO check will fail).
  • [x] Use a conventional commit message (otherwise the commit message check will fail).
  • [x] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • [x] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • [x] Github checks are green.
  • [x] Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

chtcvl avatar Oct 11 '22 09:10 chtcvl