argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

TestTemplateLevelHooks functional test is flaky

Open terrytangyuan opened this issue 3 years ago • 2 comments

Flaky functional test. Example: https://github.com/argoproj/argo-workflows/actions/runs/3053610431/jobs/4924530479


=== RUN   TestHooksSuite/TestTemplateLevelHooks
Submitting workflow  lifecycle-hook-tmpl-level-
Waiting 1m0s for workflow metadata.name=lifecycle-hook-tmpl-level-79rph
 ? lifecycle-hook-tmpl-level-79rph Workflow 0s      

 ● lifecycle-hook-tmpl-level-79rph   Workflow  0s      
 └ ● lifecycle-hook-tmpl-level-79rph Steps     0s      
 └ ◷ step-1                          HTTP      0s      
 └ ● [0]                             StepGroup 0s      

 ● lifecycle-hook-tmpl-level-79rph   Workflow  0s      
 └ ● lifecycle-hook-tmpl-level-79rph Steps     0s      
 └ ✖ step-1                          HTTP      4s      Get "http://httpstat.us/": dial tcp: lookup httpstat.us on 10.43.0.10:53: no such host
 └ ● [0]                             StepGroup 0s      

 ● lifecycle-hook-tmpl-level-79rph   Workflow  0s      
 └ ● lifecycle-hook-tmpl-level-79rph Steps     0s      
 └ ✖ step-1                          HTTP      5s      Get "http://httpstat.us/": dial tcp: lookup httpstat.us on 10.43.0.10:53: no such host
 └ ● [0]                             StepGroup 0s      
 └ ◷ step-1.onExit                   HTTP      0s      

 ● lifecycle-hook-tmpl-level-79rph   Workflow  0s      
 └ ● lifecycle-hook-tmpl-level-79rph Steps     0s      
 └ ✖ step-1                          HTTP      6s      Get "http://httpstat.us/": dial tcp: lookup httpstat.us on 10.43.0.10:53: no such host
 └ ● [0]                             StepGroup 0s      
 └ ✖ step-1.onExit                   HTTP      1s      Get "http://httpstat.us/": dial tcp: lookup httpstat.us on 10.43.0.10:53: server misbehaving

 ✖ lifecycle-hook-tmpl-level-79rph   Workflow  7s      child 'lifecycle-hook-tmpl-level-79rph-3555890967' failed
 └ ✖ lifecycle-hook-tmpl-level-79rph Steps     7s      child 'lifecycle-hook-tmpl-level-79rph-3555890967' failed
 └ ✖ step-1                          HTTP      7s      Get "http://httpstat.us/": dial tcp: lookup httpstat.us on 10.43.0.10:53: no such host
 └ ✖ [0]                             StepGroup 7s      child 'lifecycle-hook-tmpl-level-79rph-3555890967' failed
 └ ✖ step-1.onExit                   HTTP      2s      Get "http://httpstat.us/": dial tcp: lookup httpstat.us on 10.43.0.10:53: server misbehaving

    hooks_test.go:83: condition never and cannot be met because the workflow is done
Checking expectation lifecycle-hook-tmpl-level-79rph
lifecycle-hook-tmpl-level-79rph : Failed child 'lifecycle-hook-tmpl-level-79rph-3555890967' failed
    hooks_test.go:86: 
        	Error Trace:	/home/runner/work/argo-workflows/argo-workflows/test/e2e/hooks_test.go:86
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/then.go:68
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/then.go:43
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/hooks_test.go:85
        	Error:      	Not equal: 
        	            	expected: "Succeeded"
        	            	actual  : "Failed"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,2 @@
        	            	-(v1alpha1.WorkflowPhase) (len=9) "Succeeded"
        	            	+(v1alpha1.WorkflowPhase) (len=6) "Failed"
        	            	 
        	Test:       	TestHooksSuite/TestTemplateLevelHooks
Checking expectation lifecycle-hook-tmpl-level-79rph
lifecycle-hook-tmpl-level-79rph : Failed child 'lifecycle-hook-tmpl-level-79rph-3555890967' failed
Found node id=lifecycle-hook-tmpl-level-79rph-2205883422 type=HTTP
    hooks_test.go:90: 
        	Error Trace:	/home/runner/work/argo-workflows/argo-workflows/test/e2e/hooks_test.go:90
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/then.go:110
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/then.go:68
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/then.go:85
        	            				/home/runner/work/argo-workflows/argo-workflows/test/e2e/hooks_test.go:87
        	Error:      	Not equal: 
        	            	expected: "Succeeded"
        	            	actual  : "Failed"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,2 @@
        	            	-(v1alpha1.NodePhase) (len=9) "Succeeded"
        	            	+(v1alpha1.NodePhase) (len=6) "Failed"
        	            	 
        	Test:       	TestHooksSuite/TestTemplateLevelHooks
=== FAIL: HooksSuite/TestTemplateLevelHooks
FAIL	github.com/argoproj/argo-workflows/v3/test/e2e	172.192s
FAIL
make: *** [Makefile:523: test-functional] Error 1

terrytangyuan avatar Sep 14 '22 15:09 terrytangyuan

Just skip this test and create a tech-debt issue to fix later.

alexec avatar Sep 15 '22 15:09 alexec

@alexec https://github.com/argoproj/argo-workflows/pull/9598

terrytangyuan avatar Sep 15 '22 19:09 terrytangyuan