fix: TestWorkflowStepRetry's comment accurately reflects what it does.

[robertkotcher]

Update TestWorkflowStepRetry's comment to accurately reflect what it does.

Signed-off-by: rkotcher [email protected]

[robertkotcher]

Looks like the Docs failure is unrelated to changes made in this PR 🤔

[robertkotcher]

@juliev0 it looks like you have approved, but github doesn't seem to recognize that since it still says:

Merging can be performed automatically with 1 approving review

Have you seen this before? Also assuming you have write access? (looks like that is also a requirement)

Thank you!

[juliev0]

@juliev0 it looks like you have approved, but github doesn't seem to recognize that since it still says:

Merging can be performed automatically with 1 approving review

Have you seen this before? Also assuming you have write access? (looks like that is also a requirement)

Thank you!

You guessed it. I don't have permission. That "1 approving review" message is confusing. I'm a member of argo-workflows but not yet an "approver".

[robertkotcher]

@sarabala1979 you assigned to @juliev0 but it seems somebody with write perms will also need to approve. Thanks!

[robertkotcher]

@sarabala1979 seems as if somebody else will also have to click the merge button. when does that happen? (thx, just trying to learn the process here :) )

[juliev0]

@sarabala1979 seems as if somebody else will also have to click the merge button. when does that happen? (thx, just trying to learn the process here :) )

Hey Robert. Sorry for the delay. Unfortunately, some of these PRs aren't getting immediate attention. I'll bring it up to him tomorrow and hopefully we can just merge it.

[robertkotcher]

@sarabala1979 seems as if somebody else will also have to click the merge button. when does that happen? (thx, just trying to learn the process here :) )

Hey Robert. Sorry for the delay. Unfortunately, some of these PRs aren't getting immediate attention. I'll bring it up to him tomorrow and hopefully we can just merge it.

No worries :) just trying to learn the process as I'm hoping to contribute with more meaningful PRs in the future. Thanks @juliev0

[sarabala1979]

@robertkotcher sorry for the delay

[juliev0]

Thanks, @sarabala1979!

@sarabala1979 seems as if somebody else will also have to click the merge button. when does that happen? (thx, just trying to learn the process here :) )

Hey Robert. Sorry for the delay. Unfortunately, some of these PRs aren't getting immediate attention. I'll bring it up to him tomorrow and hopefully we can just merge it.

No worries :) just trying to learn the process as I'm hoping to contribute with more meaningful PRs in the future. Thanks @juliev0

Great @robertkotcher!

Thanks @sarabala1979 !