argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

Published 20 hours ago • verified publisher icon argoproj

argo terminate marks task as Succeeded instead of Failed

Open stephpalis opened this issue 2 years ago • 5 comments

Checklist

  • [ ] Double-checked my configuration.
  • [ ] Tested using the latest version.
  • [ ] Used the Emissary executor.

Summary

What happened/what you expected to happen?

  • When running argo terminate on a running workflow, it properly terminates the workflow, but marks the task as Succeeded. I would expect the workflow to be marked as Failed.

What version are you running?

  • Operator: v3.3.8
  • ArgoCLI: v3.1.0-rc13

Diagnostics

  • Launch a workflow
  • While it is still running, call argo terminate on the workflow
  • The workflow will be marked as succeeded

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

stephpalis avatar Jul 22 '22 13:07 stephpalis

Could you check if your step is a retried step? Also what's the status of the previous step? Any reproducible example and relevant controller logs? Could you run kubectl get wf <wf-name> -o yaml?

terrytangyuan avatar Jul 22 '22 14:07 terrytangyuan

Hey @terrytangyuan - I'm not quite sure how to reproduce the issue. The pod was in a pending state when I saw the bug occur, but it seems to work as expected when the pods are in a running state.

stephpalis avatar Jul 22 '22 19:07 stephpalis

I have the same problem, but I don't now how reproduce the issue.

My problem is, that when I Terminate a workflow sometimes the workflow pipeline is marked as success but see the pipeline in UI and I see that all next steps to pipeline since that I terminated workflow are omitted and marked as success.

Captura de pantalla 2022-07-22 a las 22 24 37

In this picture it can see that problem. I terminated workflow in install_dependencies, however all next steps are marked success immediately

DiegoFlop avatar Jul 22 '22 20:07 DiegoFlop

@DiegoFlop can you provide the version of Argo Workflows the operator is running and the version of Argo Workflow CLI you are using?

blkperl avatar Jul 22 '22 20:07 blkperl

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

stale[bot] avatar Aug 12 '22 04:08 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

stale[bot] avatar Oct 01 '22 06:10 stale[bot]

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

stale[bot] avatar Oct 16 '22 00:10 stale[bot]