Intermittent CI failures in Unit Tests

[juliev0]

My PR doesn't make any code changes, yet I just had two different unit test failures that passed later after an "empty commit".

Test name: TestRetriesVariableInPodSpecPatch File name: workflow/controller/operator_test.go Line: 1196 Link: https://github.com/argoproj/argo-workflows/runs/7333472812?check_suite_focus=true

Test name: TestFormulateRetryWorkflow/Nested_DAG File name: workflow/util/util_test.go Line: 910 Link: https://github.com/argoproj/argo-workflows/runs/7332453716?check_suite_focus=true

Update 7/15/22: @terrytangyuan has now fixed the second one

Test name: TestEmissary/Stdout and TestEmissary/Comined File name: emissary_test.go Lines: 45,52 Link: https://github.com/argoproj/argo-workflows/runs/7643460317?check_suite_focus=true

Test name: TestGlobalVarsOnExit File name: operator_test.go Line: 5609 Link: https://github.com/argoproj/argo-workflows/runs/7656323758?check_suite_focus=true

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

[juliev0]

note there's a separate issue related to intermittent e2e test failures in CI here

[juliev0]

@terrytangyuan I'm not sure why I saw these two intermittent unit test failures yesterday (and now they're working), but interestingly the second one above is related to a new test you added. Could you take a look and see if you have any idea why it might have failed? Thank you!

[terrytangyuan]

I'll see if I can reproduce locally.

[juliev0]

I'll see if I can reproduce locally.

Thank you!

[terrytangyuan]

I ran it 20 times and it failed only once locally.

[terrytangyuan]

@juliev0 That test case should be fixed in https://github.com/argoproj/argo-workflows/pull/9156.

[juliev0]

@juliev0 That test case should be fixed in #9156.

Thank you so much for doing that right away!!

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

[juliev0]

keeping this alive...

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

[stale[bot]]

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

[binkoni]

I encountered a similar issue today Here is the log https://github.com/argoproj/argo-workflows/actions/runs/5653773150/job/15315538326#step:4:98