argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

build timeout

Open alexec opened this issue 3 years ago • 3 comments

The functional test suite is hitting is 20m limit. 20m is a long time for a test suite to run because it means that the engineer does not have fast enough feedback. IMHO less than 10m is a good target time.

This usually happens when:

  1. A slow test has been introduced.
  2. A build step has become slow due to problems with cache.
  3. Incremental new tests push the time limit.

If it is (2), then all builds become slower. The fastest build takes about 4m20. I think that's pretty fast so it is probably not (2).

Therefore, I think it is probably (1).

Actions:

  • Look at the build and see if anything is slow (look for "slow" in the logs). Anything systemic?
  • Are there just too many tests and maybe we should break some out into a new suite?

alexec avatar Jun 22 '22 15:06 alexec

Added this one to address intermittent failures as well: https://github.com/argoproj/argo-workflows/issues/9027

juliev0 avatar Jun 22 '22 22:06 juliev0

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 06:07 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 04:07 stale[bot]

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

stale[bot] avatar Aug 12 '22 13:08 stale[bot]