argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard
verified publisher icon argoproj

The `/signal` file is not used in v3.4 and can be deleted

Open alexec opened this issue 3 years ago • 6 comments

Search for /signal in the code to find it.

alexec avatar May 11 '22 03:05 alexec

@alexec may I have a try on this ?

hzliangbin avatar May 11 '22 05:05 hzliangbin

@hzliangbin Yes feel free to submit a PR

terrytangyuan avatar May 11 '22 14:05 terrytangyuan

@alexec hi, I noticed that there is file named signal in workflow, but signalContainer is still referenced. would you mind giving me some help docs ? thx

hzliangbin avatar May 16 '22 02:05 hzliangbin

Removing assignee as there hasn't been any progress. Feel free to update here if you are still working on it.

terrytangyuan avatar Aug 16 '22 17:08 terrytangyuan

/assign @surbhiahuja

surbhiahuja avatar Sep 05 '22 13:09 surbhiahuja

Hey @surbhiahuja !! I would like to know that are you still working on this issue. If not, can I give it a try?

rakshitgondwal avatar Sep 11 '22 15:09 rakshitgondwal

@alexec hi, I noticed that there is file named signal in workflow, but signalContainer is still referenced. would you mind giving me some help docs ? thx

@hzliangbin FWIW I ran into the same issue; I can only assume the signal.SignalContainer call in signalContainers is necessary.

deepyaman avatar Oct 01 '22 21:10 deepyaman

@deepyaman yes, seems still in use。

hzliangbin avatar Oct 11 '22 06:10 hzliangbin

@terrytangyuan hi, maybe this issue could be closed

hzliangbin avatar Oct 11 '22 07:10 hzliangbin