argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

ArgoCD plugin

Open alexec opened this issue 4 years ago • 11 comments

I'd like a plugin that allows you to perform action on an Argo CD app:

  • Update and sync and wait - e.g. if you wanted a deployment
  • Delete - e.g. if you wanted a temporary app during e2e testing

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

alexec avatar Feb 17 '22 19:02 alexec

https://github.com/UrielCohen456/argo-workflows-argocd-executor-plugin.git

alexec avatar Feb 28 '22 23:02 alexec

I can work on this

NikeNano avatar Mar 10 '22 14:03 NikeNano

@NikeNano do you want to reach out to @UrielCohen456?

alexec avatar Mar 10 '22 15:03 alexec

Do we intend to use Python or go for the officials plugins or the language don't matter in this case?

NikeNano avatar Mar 10 '22 20:03 NikeNano

We don't have "official plugins" really. I expect many users to want to use Python as it is popular in ML community, which Argo is popular in. But there's not recommendation. For example, some users might have existng Java code then wish to use. They would want to write their plugin in Java.

alexec avatar Mar 10 '22 22:03 alexec

I have not managed to get hold of @UrielCohen456 but will start the work for this. Where do we want to have the plugin? Which repo?

NikeNano avatar Mar 14 '22 13:03 NikeNano

https://github.com/UrielCohen456/argo-workflows-argocd-executor-plugin.git

alexec avatar Mar 14 '22 14:03 alexec

https://github.com/UrielCohen456/argo-workflows-argocd-executor-plugin.git

Dont fully follow now? Do you refer to that what @UrielCohen456 has created is sufficient?

NikeNano avatar Mar 14 '22 15:03 NikeNano

Hey, I havn't had the time to work on this yet. I honestly don't think my programming skills are well enough for something official. I started learning go recently as I don't think python is good for long term usage on this kind of project.

If you would like I would gladly give the repository name or ownership to someone else. I just started it as a way to experiment and learn for myself 😉

UrielCohen456 avatar Mar 18 '22 10:03 UrielCohen456

We have 5x 👍 , so users want this.

alexec avatar Mar 18 '22 16:03 alexec

@NikeNano Did you get a chance to work on it? :)

DanishKhakwani avatar Sep 13 '22 22:09 DanishKhakwani

I took a crack at it: https://github.com/UrielCohen456/argocd-executor-plugin/pull/5

@UrielCohen456 if you don't want to merge, I can leave it on my fork. But I don't think I'll be able to maintain it long-term. Hopefully someone can pick it up now that we have basic functionality in place.

crenshaw-dev avatar Oct 30 '22 23:10 crenshaw-dev

Noting here that this is very possible with templates, and that there is a template in argoproj-labs/argo-workflows-catalog that does this. A plugin could have nicer UX though.

@UrielCohen456 if you don't want to merge, I can leave it on my fork. But I don't think I'll be able to maintain it long-term. Hopefully someone can pick it up now that we have basic functionality in place.

For reference, a link to that fork: https://github.com/crenshaw-dev/argocd-executor-plugin

I wonder if we want to keep a fork in argoproj-labs for (slightly?) better visibility or as a "main fork" or something

agilgur5 avatar Nov 20 '23 07:11 agilgur5