argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

UI: Inactivate buttons for actions not allowed by current permissions

Open Radolumbo opened this issue 4 years ago • 4 comments

Summary

Recently made a change to the argo-server role permissions to prevent our users from creating things via the UI. Based this on the recommendation here: https://argoproj.github.io/argo-workflows/security/#read-only

It would be REALLY nice if the Argo UI was aware of the fact that the current user does not have permission to, say, "+SUBMIT NEW WORKFLOW" and greyed out that button. Instead, it is still clickable, and just fails when the user tries to create a workflow.

Use Cases

Any time you want to use the UI as a read-only option (or any iteration of permissions on the server, maybe you only want to block users from deleting workflow, then that button should grey out).


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Radolumbo avatar Jun 28 '21 22:06 Radolumbo

Honestly, I might even argue this is a bug...

Radolumbo avatar Jun 28 '21 22:06 Radolumbo

Great point, I'll work on this

simster7 avatar Jun 28 '21 22:06 simster7

@simster7 Any update on this? Might look to pick this up on my team sometime soon if not.

Radolumbo avatar Aug 12 '21 23:08 Radolumbo

Sorry, haven;t had a chance to work on this. Feel free to pick it up @Radolumbo

simster7 avatar Aug 26 '21 20:08 simster7