argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

Published 20 hours ago • verified publisher icon argoproj

Migrate toward structured logging

Open simster7 opened this issue 5 years ago • 4 comments

Some parts of the code already have structured logging -- for example:

https://github.com/argoproj/argo/blob/214c451535ebeb6e68f1599c2c0a4a4d174ade25/persist/sqldb/workflow_archive.go#L63-L64

But most don't. Let's migrate the rest.

#2307

simster7 avatar Feb 25 '20 15:02 simster7

Available for testing in v2.10.0-rc1.

alexec avatar Sep 02 '20 15:09 alexec

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 02 '22 14:03 stale[bot]

Hope this PR: https://github.com/argoproj/argo-workflows/pull/9779 can help you. Hi @alexec and @simster7, please help me to review it

VUHAILAM avatar Oct 09 '22 20:10 VUHAILAM

Hi @simster7 @sarabala1979 , I submitted #9844 as a continuation of this issue fix (for hacktoberfest 🎃). I started with the log.Fatal(err) primarily to confirm that the approach is correct. Please let me know of any feedback and I can work on the remaining Fatal logs with fields, i.e. Fatalf ones.

rylim avatar Oct 17 '22 02:10 rylim

Hi, is this still available to work on ?

KyriosGN0 avatar Jun 08 '24 18:06 KyriosGN0