argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

Enable linting for `kmsId` and `nodeId` fields

Open djanjic opened this issue 7 months ago • 0 comments

Summary

kmsId and nodeId fields are excluded from linting (ST1003) since this change affects generated files (like proto and swagger) and is a breaking change. Also, changing these files adds new entries to pkg/apis/api-rules/violation_exceptions.list.

For more info, check:

  • https://github.com/argoproj/argo-workflows/pull/14520/files#diff-94d0f1284fafd0a1cb05dc2309b4be043b6fb01d66626ab1867d40c84b573ec2L1367
  • https://github.com/argoproj/argo-workflows/pull/14520/files#diff-94d0f1284fafd0a1cb05dc2309b4be043b6fb01d66626ab1867d40c84b573ec2L2592
  • https://github.com/argoproj/argo-workflows/pull/14520

Use Cases

Just code and style improvements.


Message from the maintainers:

Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.

djanjic avatar May 28 '25 10:05 djanjic