argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

chore(deps)!: bump k8s dependencies to 1.30

Open blkperl opened this issue 1 year ago • 5 comments

Motivation

  • K8s 1.26 is no longer receiving security patches

Modifications

  • updated go.mod to k8s 1.30
  • updated dist/kubernetes.swagger.json version to 1.30
  • updated workflow/executor/resource.go to non deprecated functions to appease the linter
  • updated from [email protected] to [email protected]
  • updated various files to the new ptr library to appease the linter
  • changed the metrics test contains assertion from status_code=200 to status_code=400 to pass the test
  • changed getEvents test helper to truncate annotations from events so that TestEventNodeEvents passes

Verification

Existing test coverage

blkperl avatar Jul 30 '24 01:07 blkperl

@agilgur5 is the mysql test a known failure or did the PR somehow break the metric?

blkperl avatar Jul 30 '24 16:07 blkperl

I don't recall this as a prior flake. You can re-run individual failed tests now (#13000) with a /retest comment to verify a flake. See my below comment as an example

agilgur5 avatar Jul 30 '24 17:07 agilgur5

/retest

agilgur5 avatar Jul 30 '24 17:07 agilgur5

hey @terrytangyuan could you take a look please? It's one PR like you requested in https://github.com/argoproj/argo-workflows/pull/12865

blkperl avatar Aug 09 '24 19:08 blkperl

Thank you for this! Since this is a breaking change, we cannot merge now.

terrytangyuan avatar Aug 10 '24 02:08 terrytangyuan

@terrytangyuan, any reason not to merge this to main only, which will become 3.6?

Joibel avatar Sep 11 '24 10:09 Joibel

You are right. We should merge it to main. Do you want to do another review?

@blkperl Could you resolve the conflicts? Thanks!

terrytangyuan avatar Sep 11 '24 12:09 terrytangyuan

@terrytangyuan I've resolved the conflicts. Thanks!

blkperl avatar Sep 11 '24 22:09 blkperl

/retest

blkperl avatar Sep 12 '24 14:09 blkperl