argo-workflows
argo-workflows copied to clipboard
chore(deps)!: bump k8s dependencies to 1.30
Motivation
- K8s 1.26 is no longer receiving security patches
Modifications
- updated
go.modto k8s 1.30 - updated
dist/kubernetes.swagger.jsonversion to 1.30 - updated
workflow/executor/resource.goto non deprecated functions to appease the linter - updated from [email protected] to [email protected]
- updated various files to the new ptr library to appease the linter
- changed the metrics test contains assertion from status_code=200 to status_code=400 to pass the test
- changed
getEventstest helper to truncate annotations from events so thatTestEventNodeEventspasses
Verification
Existing test coverage
@agilgur5 is the mysql test a known failure or did the PR somehow break the metric?
I don't recall this as a prior flake. You can re-run individual failed tests now (#13000) with a /retest comment to verify a flake. See my below comment as an example
/retest
hey @terrytangyuan could you take a look please? It's one PR like you requested in https://github.com/argoproj/argo-workflows/pull/12865
Thank you for this! Since this is a breaking change, we cannot merge now.
@terrytangyuan, any reason not to merge this to main only, which will become 3.6?
You are right. We should merge it to main. Do you want to do another review?
@blkperl Could you resolve the conflicts? Thanks!
@terrytangyuan I've resolved the conflicts. Thanks!
/retest