argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

fix: consistently set executor log options

Open agilgur5 opened this issue 2 months ago • 2 comments

Fixes #12788, Fixes https://github.com/argoproj/argo-workflows/pull/12929#discussion_r1572707894

Motivation

  • loglevel, gloglevel, and log format were inconsistently set around the codebase for executor containers
    • meaning that some had partial settings and some had no settings, depending on the command run etc

Modifications

  • for all commands, including emissary, agent, resource, and data

    • set loglevel, gloglevel, and log format
  • replace getExecutorLogLevel helper with getExecutorLogOpts helper

  • add a helper in util/cmd/glog.go to get the gloglevel

Verification

Existing tests pass

agilgur5 avatar Apr 24 '24 18:04 agilgur5

You mean making this line more specific?

I didn't change the option in this PR, just made it actually used, but could improve that for sure

agilgur5 avatar May 01 '24 20:05 agilgur5

Merged main for new checks per #13027

agilgur5 avatar May 22 '24 19:05 agilgur5