argo-workflows
argo-workflows copied to clipboard
fix: consistently set executor log options
Fixes #12788, Fixes https://github.com/argoproj/argo-workflows/pull/12929#discussion_r1572707894
Motivation
- loglevel, gloglevel, and log format were inconsistently set around the codebase for executor containers
- meaning that some had partial settings and some had no settings, depending on the command run etc
Modifications
-
for all commands, including
emissary
,agent
,resource
, anddata
- set loglevel, gloglevel, and log format
-
replace
getExecutorLogLevel
helper withgetExecutorLogOpts
helper -
add a helper in
util/cmd/glog.go
to get the gloglevel
Verification
Existing tests pass
You mean making this line more specific?
I didn't change the option in this PR, just made it actually used, but could improve that for sure
Merged main
for new checks per #13027