argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

chore!: remove legacy `patch` `pods` fallback

Open agilgur5 opened this issue 2 months ago • 3 comments

Motivation

  • the fallback is old and insecure, and the error confuses users as it's not mentioned in the docs (as it's legacy and a fallback)
    • e.g. #12783 and also frequently on Slack
  • it's also tech debt that we have to write code around specifically right now
  • it's no longer needed and hasn't been the main RBAC in a few versions, so remove it in the next breaking minor release

Modifications

  • remove the Executor code that patches pods
  • remove the operator code that reads the patched annotations

Verification

Tests pass

agilgur5 avatar Apr 24 '24 02:04 agilgur5

@Garett-MacGowan would you be interested in taking over this PR? This seems to need more refactoring than I anticipated (given the failing tests) and I know you've worked with some of these pod annotations before

agilgur5 avatar Apr 24 '24 19:04 agilgur5

Hey! Sorry for the late response, I've been swamped. I can try and take a look at this some time next week.

Garett-MacGowan avatar May 13 '24 00:05 Garett-MacGowan