argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

fix(ui): show container logs when using `templateRef`

Open agilgur5 opened this issue 2 months ago • 4 comments

Fixes #9938 Related to #12970 -- that's for the back-end, this is the one remaining place in the front-end

Motivation

  • the component was incorrectly assuming that node.templateName exists, which it doesn't in the case of a templateRef

Modifications

  • use the existing getTemplateNameFromNode function to properly handle that instead

Verification

Used the WorkflowTemplate and Workflow from the issue repro, can see all containers and logs.

Screenshot:

Screenshot 2024-04-23 at 9 11 37 PM

agilgur5 avatar Apr 24 '24 01:04 agilgur5