argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

fix: Set default value to output parameters if suspend node timeout. Fixes #12230

Open jswxstw opened this issue 1 year ago • 1 comments

Fixes #12230

Motivation

Node is marked to Succeeded when suspension is expired, but the value of node outputs parameters was not filled up with ValueFrom.Default if ValueFrom.Supplied != nil.

Modifications

Set default value to output parameters if suspend node timeout or mark the suspend node to error if raw output parameter has not been set and does not have a default value.

Verification

local test and add e2e test

jswxstw avatar Apr 22 '24 03:04 jswxstw

The test-corefunctional, minimal was succeed before the last commit 2317852, The last commit only alters the functional test, the test-corefunctional, minimal failure is not an issue

tczhao avatar Apr 23 '24 04:04 tczhao