fix: Allow users to selectively retry specific failed nodes . Fixes #12543

[mio4kon]

Fixes #12543

Motivation

Allow users to selectively retry specific failed nodes instead of retrying all failed nodes at once.

Modifications

Removed the restriction that required the simultaneous use of --node-field-selector and --restart-successful. Now, using --node-field-selector alone allows for individual retries of specific failed nodes, instead of retrying all failures.

Verification

--node-field-selector can be used independently. ./dist/argo retry fail-24ptx --node-field-selector name=fail-24ptx.BB -v

Regressively used in combination. ./dist/argo retry fail-mz9c4 --restart-successful --node-field-selector name=fail-mz9c4.A

[agilgur5]

feat: [...]

Please re-title this PR as a fix:, since per https://github.com/argoproj/argo-workflows/issues/12543#issuecomment-1900910489 this very much seems like a bug and not intended behavior

[mio4kon]

feat: [...]

Please re-title this PR as a fix:, since per #12543 (comment) this very much seems like a bug and not intended behavior

done

[mio4kon]

@agilgur5 hello，Will this MR be merged into the trunk in the future?

[tooptoop4]

:shipit:

[mio4kon]

Can you add two e2e tests please? One that is a dag and one that is not.

Don't stress about invoking the server if there isn't infrastructure for those kind of tests (although I suspect you should be able to use REST) already.

Just add those two tests with comments linking them to this issue and PR.

@isubasinghe add e2e tests : TestRetryWorkflowWithStepsWithSelectedFailNodes and TestRetryWorkflowWithDAGWithSelectedFailNodes, Please help to check it out workflow/util/util_test.go

[JasonChen86899]

Hi, I review the logic and this modification may cause problems. The current logic of the main branch is to not retry the error node with successful child nodes. This modification will result in some errors