argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

Full CRD installation fails

Open ramanNarasimhan77 opened this issue 1 year ago • 5 comments

Pre-requisites

  • [X] I have double-checked my configuration
  • [X] I can confirm the issues exists when I tested with :latest
  • [ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

I tried installing the FULL CRD by updating the kustomization.yaml

$ git diff manifests/base/crds/kustomization.yaml
diff --git a/manifests/base/crds/kustomization.yaml b/manifests/base/crds/kustomization.yaml
index 3ccdade18..4bc23b6ee 100644
--- a/manifests/base/crds/kustomization.yaml
+++ b/manifests/base/crds/kustomization.yaml

@@ -2,4 +2,4 @@ apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization

 resources:
-  - minimal
+  - full

$ kubectl create ns argo
$ kubectl apply -k manifests/cluster-install

Errors:

Error from server (Invalid): error when creating "manifests/cluster-install": CustomResourceDefinition.apiextensions.k8s.io "clusterworkflowtemplates.argoproj.io" is invalid: [spec.validation.openAPIV3Schema.properties[spec].properties[templateDefaults].properties[dag].properties[tasks].items.properties[inline].type: Required value: must not be empty for specified object fields, spec.validation.openAPIV3Schema.properties[spec].properties[templateDefaults].properties[steps].items.items: Required value: must be specified, spec.validation.openAPIV3Schema.properties[spec].properties[templates].items.properties[dag].properties[tasks].items.properties[inline].type: Required value: must not be empty for specified object fields, spec.validation.openAPIV3Schema.properties[spec].properties[templates].items.properties[steps].items.items: Required value: must be specified]


Error from server (Invalid): error when creating "manifests/cluster-install": CustomResourceDefinition.apiextensions.k8s.io "workflows.argoproj.io" is invalid: [metadata.annotations: Too long: must have at most 262144 bytes, spec.validation.openAPIV3Schema.properties[spec].properties[templateDefaults].properties[dag].properties[tasks].items.properties[inline].type: Required value: must not be empty for specified object fields, spec.validation.openAPIV3Schema.properties[spec].properties[templateDefaults].properties[steps].items.items: Required value: must be specified, spec.validation.openAPIV3Schema.properties[spec].properties[templates].items.properties[dag].properties[tasks].items.properties[inline].type: Required value: must not be empty for specified object fields, spec.validation.openAPIV3Schema.properties[spec].properties[templates].items.properties[steps].items.items: Required value: must be specified, spec.validation.openAPIV3Schema.properties[status].properties[storedTemplates].additionalProperties.properties[dag].properties[tasks].items.properties[inline].type: Required value: must not be empty for specified object fields, spec.validation.openAPIV3Schema.properties[status].properties[storedTemplates].additionalProperties.properties[steps].items.items: Required value: must be specified, spec.validation.openAPIV3Schema.properties[status].properties[storedWorkflowTemplateSpec].properties[templateDefaults].properties[dag].properties[tasks].items.properties[inline].type: Required value: must not be empty for specified object fields, spec.validation.openAPIV3Schema.properties[status].properties[storedWorkflowTemplateSpec].properties[templateDefaults].properties[steps].items.items: Required value: must be specified, spec.validation.openAPIV3Schema.properties[status].properties[storedWorkflowTemplateSpec].properties[templates].items.properties[dag].properties[tasks].items.properties[inline].type: Required value: must not be empty for specified object fields, spec.validation.openAPIV3Schema.properties[status].properties[storedWorkflowTemplateSpec].properties[templates].items.properties[steps].items.items: Required value: must be specified]


Error from server (Invalid): error when creating "manifests/cluster-install": CustomResourceDefinition.apiextensions.k8s.io "workflowtasksets.argoproj.io" is invalid: [spec.validation.openAPIV3Schema.properties[spec].properties[tasks].additionalProperties.properties[dag].properties[tasks].items.properties[inline].type: Required value: must not be empty for specified object fields, spec.validation.openAPIV3Schema.properties[spec].properties[tasks].additionalProperties.properties[steps].items.items: Required value: must be specified]
Error from server (Invalid): error when creating "manifests/cluster-install": CustomResourceDefinition.apiextensions.k8s.io "workflowtemplates.argoproj.io" is invalid: [spec.validation.openAPIV3Schema.properties[spec].properties[templateDefaults].properties[dag].properties[tasks].items.properties[inline].type: Required value: must not be empty for specified object fields, spec.validation.openAPIV3Schema.properties[spec].properties[templateDefaults].properties[steps].items.items: Required value: must be specified, spec.validation.openAPIV3Schema.properties[spec].properties[templates].items.properties[dag].properties[tasks].items.properties[inline].type: Required value: must not be empty for specified object fields, spec.validation.openAPIV3Schema.properties[spec].properties[templates].items.properties[steps].items.items: Required value: must be specified]

Reported this issue first in this discussion - https://github.com/argoproj/argo-workflows/discussions/11208#discussioncomment-6210750

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

NA

Logs from the workflow controller

NA

Logs from in your workflow's wait container

NA

ramanNarasimhan77 avatar Jun 26 '23 05:06 ramanNarasimhan77

So, this is how it's being created by the Makefile: https://github.com/argoproj/argo-workflows/blob/master/Makefile#L392 Can you try that?

juliev0 avatar Jun 29 '23 17:06 juliev0

Full CRDs are not intended to be installed, only for usage in editors. They will not work.

alexec avatar Jul 16 '23 21:07 alexec

This needs to be addressed in the README

jackivanov avatar Jul 20 '23 15:07 jackivanov

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 17 '23 10:09 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity and needs more information. It will be closed if no further activity occurs.

github-actions[bot] avatar Jan 12 '24 02:01 github-actions[bot]

This needs to be addressed in the README

It's already in the Full CRD README and has been for years -- the full CRDs are generally too large and so the error from OP is expected, as the README states. Not sure if that's what you meant, but that does seem like an appropriate place to document it as the Full CRDs are otherwise unused during installation.

agilgur5 avatar Jun 22 '24 01:06 agilgur5